Basic QTI zip loading prototype. #8070
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtibbles
force-pushed
the
qti
branch
2 times, most recently
from
8153bf9 to
c4c00bf
Compare
kolibri/plugins/qti_viewer/assets/src/views/AssessmentItemRef.vue
Outdated
Show resolved
Hide resolved
Comment on lines
+40
to
+43
| return new URL( | ||
| relativeHref, | ||
| new URL(this.getFilePath(), 'http://b.b/') | ||
| ).pathname.substring(1); |
There was a problem hiding this comment.
A little clarification
Suggested change
| return new URL( | |
| relativeHref, | |
| new URL(this.getFilePath(), 'http://b.b/') | |
| ).pathname.substring(1); | |
| // iterative URL path construction using dummy domain | |
| return new URL( | |
| relativeHref, | |
| new URL(this.getFilePath(), 'http://example.com/') | |
| ).pathname.substring(1); |
There was a problem hiding this comment.
I deliberately used a non-valid TLD to avoid any confusion, but yes.
rtibbles
force-pushed
the
develop
branch
3 times, most recently
from
8c58c23 to
7149993
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References
…
Reviewer guidance
…
Testing checklist
PR process
Reviewer checklist
yarnandpip)